Read single precision fluid field in RAMSES#5207
Read single precision fluid field in RAMSES#5207AnatoleStorck wants to merge 20 commits intoyt-project:mainfrom
Conversation
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
chrishavlin
added
enhancement
|
For reviewers: testing is complicated as all the RAMSES datasets at hand are stored in double precision! |
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
LGTM! left some minor coding style comments...
| fields = [ "Potential,f", "Potential-old,f", "x-acceleration,f", "y-acceleration,f", "z-acceleration,f" ] | ||
|
|
||
| Importantly, the order of the fields should match the order in which they are written in the RAMSES output files. | ||
| yt will also assume that each entry is formed of a field name followed by its type (``f`` for single precision, ``d`` for double precision), separated by a comma. Field names containing commas are not supported, other precisions (e.g. integers) are not supported either. All fields in a given file type (gravity, hydro, ...) need to have the same precision. |
There was a problem hiding this comment.
is it worth a mention that though yt can read in the single precision case, they will be converted to double precision for use within yt?
cphyc
force-pushed
the
read_single_precision_fluid_field
branch
from
fc470fb to
6a38fe7
Compare
|
@chrishavlin I've updated the PR. |
|
@cphyc, Looks good to me, and is much more generalized than what I had implemented. |
|
test failure was an unrelated timeout error, kicked it off again. |
3 participants
PR Summary
The current back-end for reading RAMSES fluid fields assumes the data is double precision. This PR (in collaboration with @cphyc ) is an initial expansion of the RAMSES fluid reader to read single precision fields. For my simulations, the RT fields are written in single precision so this change is needed to read them in.
PR Checklist