[BUG/ENH] RAMSES: Support non-Hilbert decomposition#5340
Open
cphyc wants to merge 1 commit intoyt-project:mainfrom
Open
[BUG/ENH] RAMSES: Support non-Hilbert decomposition#5340cphyc wants to merge 1 commit intoyt-project:mainfrom
cphyc wants to merge 1 commit intoyt-project:mainfrom
Conversation
cphyc
added
bug
code frontends
cphyc
force-pushed
the
RAMSES/support-other-domain-decomposition
branch
from
7fd150e to
b1470f8
Compare
3 tasks
nbrucy
pushed a commit
to ramses-organisation/ramses
that referenced
this pull request
Dec 19, 2025
<!-- Thank you so much for your contribution! --> <!-- First describe what your PR is doing. --> This PR fixes the issue #72 Thanks to @cphyc for the help and for adapting Yt to add support on this bisection decomposition (see yt-project/yt#5340)
chrishavlin
approved these changes
Dec 19, 2025
Contributor
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
Since this was confirmed to fix the issue upstream, I think we're good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ramses-organisation/ramses#72.
PR Summary
RAMSES has a well-hidden option to use a domain-decomposition strategy that isn't based on a Hilbert curve decomposition. This PR adds support for this case. Unfortunately, due to the rarity of this option, I don't have any dataset at hand to test it, but my colleagues (@matthiasglz) confirmed this fixed the issue.