Ensure preserve_source_parameters restores state on exception#5377
Open
yaochengchen wants to merge 2 commits intoyt-project:mainfrom
Open
Ensure preserve_source_parameters restores state on exception#5377yaochengchen wants to merge 2 commits intoyt-project:mainfrom
yaochengchen wants to merge 2 commits intoyt-project:mainfrom
Conversation
chrishavlin
reviewed
Feb 13, 2026
Contributor
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
Thanks for the thorough test here, looks good to me, but would be nice to add a comment in the code.
Co-authored-by: Chris Havlin <chris.havlin@gmail.com>
Author
Thanks @chrishavlin for the comment & review. |
chrishavlin
approved these changes
Feb 18, 2026
Contributor
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
lgtm once tests pass again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes a bug in preserve_source_parameters where source.field_parameters was not restored if the wrapped function raised an exception.
The function call is now wrapped in a try/finally block to guarantee state restoration.
A regression test has been added to ensure correct behavior.
PR Checklist
Adds a test for any bugs fixed. Adds tests for new features.