Skip to content

added value overrides for master broadcastaddress #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssung-yugabyte wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added value overrides for master broadcastaddress #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38cd398
added value overrides for master broadcastaddress
ssung-yugabyte Feb 2, 2022
75ee316
Merge branch 'yugabyte:master' into master
ssung-yugabyte Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stable/yugabyte/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ spec:
--allow_insecure_connections={{ $root.Values.tls.insecure }} \
{{- end }}
--rpc_bind_addresses={{ $rpcAddr }} \
--server_broadcast_addresses={{ $broadcastAddr }} \
--server_broadcast_addresses={{ $root.Values.master.serverBroadcastAddress | default $broadcastAddr }} \
--webserver_interface={{ $webserverAddr }}
{{- else }}
{{- $cqlAddr := include "yugabyte.cql_proxy_bind_address" $serviceValues -}}
Expand Down Expand Up @@ -386,7 +386,7 @@ spec:
--undefok=num_cpus,enable_ysql \
--use_node_hostname_for_local_tserver=true \
{{- if $root.Values.authCredentials.ysql.password }}
--ysql_enable_auth=true \
--ysql_enable_auth=true
Copy link
Copy Markdown

@tvesely tvesely Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo. This line should be removed.

Copy link
Copy Markdown
Contributor

@iSignal iSignal Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvesely : is Stanley around to update this PR? Otherwise, can you please send a new PR with the typo removed?

Copy link
Copy Markdown
Contributor

@bhavin192 bhavin192 Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvesely you mean we should not remove the trailing slash, right?
Cause if we remove this line, a feature used by community users, might stop working.

charts/stable/yugabyte/values.yaml

Lines 293 to 302 in 8ae394e

# For more https://docs.yugabyte.com/latest/reference/configuration/yugabyted/#environment-variables
authCredentials:
ysql:
user: ""
password: ""
database: ""
ycql:
user: ""
password: ""
keyspace: ""

{{- end }}
{{- if or $root.Values.authCredentials.ycql.user $root.Values.authCredentials.ycql.password }}
--use_cassandra_authentication=true \
Expand Down