[CDCSDK] Remove dependency on JDBC connection for decoding values#142
Open
fourpointfour wants to merge 5 commits intomainfrom
Open
[CDCSDK] Remove dependency on JDBC connection for decoding values#142fourpointfour wants to merge 5 commits intomainfrom
fourpointfour wants to merge 5 commits intomainfrom
Conversation
fourpointfour
commented
Jan 18, 2023
| @@ -0,0 +1,180 @@ | |||
| package io.debezium.connector.yugabytedb.connection; | |||
Contributor
Author
There was a problem hiding this comment.
This file is for verifying the changes for the time being. IMO this is not even required as we already send the decoded values from the server, we simply need to parse those values properly which is what the current changes in YugabyteDBValueConverter is doing.
vrajat
suggested changes
Jan 19, 2023
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBChangeRecordEmitter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBChangeRecordEmitter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBValueConverter.java
Outdated
Show resolved
Hide resolved
.../java/io/debezium/connector/yugabytedb/connection/ReplicationMessageColumnValueResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/io/debezium/connector/yugabytedb/connection/pgproto/YbProtoColumnValue.java
Show resolved
Hide resolved
vrajat
reviewed
Jan 19, 2023
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
suranjan
reviewed
Jan 19, 2023
|
|
||
| protected synchronized YBArrayList buildArrayList(String fieldString) throws SQLException { | ||
| if (this.arrayList == null) { | ||
| // TODO Vaibhav: You may need to make the delimiter call dependent on oid |
Collaborator
There was a problem hiding this comment.
This delimeter call we should do in Connector and send to all the tasks.
| dataString = dataString.substring(1, dataString.length() - 1); | ||
| return dataString.split(","); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Instead of this, can't we just resuse the method of pgArray/YBArray by passing the default delimeter.
Ideally it should be able to handle recursion 2d/3d arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the changes for: