Skip to content

Remove ff/fb terminology in code #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makalaaneesh wants to merge 2 commits into
base: voyager-main
Choose a base branch
from
Open

Remove ff/fb terminology in code #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a934a
refactor MSR
makalaaneesh Nov 21, 2023
cab8d7b
workflow for adding changes to 1.9.5
makalaaneesh Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/voyager-debezium-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ jobs:
rm debezium-server-latest-1.9.5.tar.gz
mv debezium-server debezium-server-1.9.5

# cp built yb-exporter to 1.9.5
cd ${GITHUB_WORKSPACE}
cd debezium-server/debezium-server-dist/target/debezium-server
cp lib/debezium-server-ybexporter-2.2.0-SNAPSHOT.jar debezium-server-1.9.5/lib/

# package yb-client-cdc-stream-wrapper.jar into debezium-server
cd ${GITHUB_WORKSPACE}
mv yb-client-cdc-stream-wrapper/target/yb-client-cdc-stream-wrapper.jar debezium-server/debezium-server-dist/target/debezium-server/debezium-server-1.9.5/
Expand Down
12 changes: 6 additions & 6 deletions .../debezium-server-ybexporter/src/main/java/io/debezium/server/ybexporter/ExportStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,12 @@ public boolean checkIfSwitchOperationRequested(String operation) throws SQLExcep
while (rs.next()) {
MigrationStatusRecord msr = MigrationStatusRecord.fromJsonString(rs.getString("json_text"));
switch(operation.toString()) {
case "cutover":
return msr.CutoverRequested;
case "fallforward":
return msr.FallForwardSwitchRequested;
case "fallback":
return msr.FallBackSwitchRequested;
case "cutover.target":
return msr.CutoverToTargetRequested;
case "cutover.source_replica":
return msr.CutoverToSourceReplicaRequested;
case "cutover.source":
return msr.CutoverToSourceRequested;
}
}
} catch (SQLException e) {
Expand Down
16 changes: 8 additions & 8 deletions ...-server-ybexporter/src/main/java/io/debezium/server/ybexporter/MigrationStatusRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ public class MigrationStatusRecord {
public String ExportType;
public boolean FallForwarDBExists;
public List<String> TableListExportedFromSource;
public boolean CutoverRequested;
public boolean CutoverToTargetRequested;
public boolean CutoverProcessedBySourceExporter;
public boolean CutoverProcessedByTargetImporter;
public boolean FallForwardSyncStarted;
public boolean FallForwardSwitchRequested;
public boolean FallForwardSwitchProcessedByTargetExporter;
public boolean FallForwardSwitchProcessedByFFImporter;
public boolean FallBackSwitchRequested;
public boolean FallBackSwitchProcessedByTargetExporter;
public boolean FallBackSwitchProcessedByFBImporter;
public boolean ExportFromTargetFallForwardStarted;
public boolean CutoverToSourceReplicaRequested;
public boolean CutoverToSourceReplicaProcessedByTargetExporter;
public boolean CutoverToSourceReplicaProcessedBySRImporter;
public boolean CutoverToSourceRequested;
public boolean CutoverToSourceProcessedByTargetExporter;
public boolean CutoverToSourceProcessedBySourceImporter;
public boolean ExportSchemaDone;
public boolean ExportDataDone;

Expand Down
6 changes: 3 additions & 3 deletions ...ium-server-ybexporter/src/main/java/io/debezium/server/ybexporter/YbExporterConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ void flush() {
LOGGER.info("XXX Started flush thread.");
String switchOperation;
if (exporterRole.equals(SOURCE_DB_EXPORTER_ROLE)){
switchOperation = "cutover";
switchOperation = "cutover.target";
}
else if (exporterRole.equals(TARGET_DB_EXPORTER_FF_ROLE)){
switchOperation = "fallforward";
switchOperation = "cutover.source_replica";
}
else if (exporterRole.equals(TARGET_DB_EXPORTER_FB_ROLE)){
switchOperation = "fallback";
switchOperation = "cutover.source";
}
else {
throw new RuntimeException(String.format("invalid exportRole %s", exporterRole));
Expand Down