Merged
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
@makalaaneesh take a look at line no 158
No fall-forward/back enabled. Exiting.
| ExportType string `json:"ExportType"` | ||
| // FallForwarDBExists bool `json:"FallForwarDBExists"` | ||
| ArchivingEnabled bool `json:"ArchivingEnabled"` | ||
| FallForwardEnabled bool `json:"FallForwardEnabled"` |
Contributor
There was a problem hiding this comment.
are you going to rename this also?
Collaborator
Author
There was a problem hiding this comment.
I consciously did not. My thought process is:
Rename everything related to
- setup/synchronize
- fallforwardDB->sourceReplicaDB
- fallforward/back switchover -> cutover to *
It still makes sense to have the notion of the fall-forward/fall-back "workflows" as such.
In this example, because we are importing to source-replica, the "fallforward workflow" is enabled. Another example is that during cutover we have a flag "--prepare-for-fall-back".
So we still have that terminology, but just in the context of the workflows; and not in the context of commands/DBs. Makes sense?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBZM PR: yugabyte/debezium#99