Fix an overflow in is_staleness_acceptable#30286
Open
ali-a-a wants to merge 1 commit intoyugabyte:masterfrom
Open
Fix an overflow in is_staleness_acceptable#30286ali-a-a wants to merge 1 commit intoyugabyte:masterfrom
ali-a-a wants to merge 1 commit intoyugabyte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15011.
Right now, the maximum value for
yb_follower_read_staleness_msis set toINT_MAX(source), and the current code overflows when it gets multiplied by 1000 inis_staleness_acceptable. This PR fixes this problem by casting it intoint64_twhile doing the comparison.