Fix THREAD_POOL_METRICS_INSTANCE macro using wrong metric#30621
Open
ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
Open
Fix THREAD_POOL_METRICS_INSTANCE macro using wrong metric#30621ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
ellabaron-code wants to merge 1 commit intoyugabyte:masterfrom
Conversation
The first field in the THREAD_POOL_METRICS_INSTANCE macro was incorrectly using _run_time_us (duplicate of the third field) instead of _queue_length, causing the queue_length metric to never be instantiated for thread pools. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THREAD_POOL_METRICS_INSTANCEmacro was incorrectly using_run_time_us(duplicate of the third field) instead of_queue_lengthqueue_lengthmetric to never be instantiated for thread poolsTest plan
THREAD_POOL_METRICS_DEFINEmacro order:queue_length,queue_time_us,run_time_us./yb_build.sh release --ninjaNote
Low Risk
Low risk macro fix that only changes which metrics are instantiated for thread pools; primary impact is on metric visibility rather than runtime behavior.
Overview
Fixes
THREAD_POOL_METRICS_INSTANCEinthreadpool.hto instantiate the missing*_queue_lengthmetric instead of duplicating*_run_time_us, aligning the instance macro withTHREAD_POOL_METRICS_DEFINEso thread pools now publish queue length stats as intended.Written by Cursor Bugbot for commit 02c724c. This will update automatically on new commits. Configure here.