deploy: Deployment, remove command and let the entrypoint run#13
Open
mcuadros wants to merge 1 commit intoyugabyte:masterfrom
Open
deploy: Deployment, remove command and let the entrypoint run#13mcuadros wants to merge 1 commit intoyugabyte:masterfrom
mcuadros wants to merge 1 commit intoyugabyte:masterfrom
Conversation
Contributor
|
@samkulkarni20 pointed it out that our docker image was old, just pushed the latest changes to our docker repo, can you test it now?. This change might not be needed with the latest image cc @samkulkarni20 |
Author
|
Even if with a newer image work, this having the command written down disallow anyone to use older versions, or in the future, if you change the command again. So maybe it is a good idea to remove it, and let the entry command work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12