Skip to content

Print exceptions and pass exception error object into results #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aljimenez wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Print exceptions and pass exception error object into results #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7e196
Pass exception error object into results
aljimenez May 28, 2014
1849c71
Print exception stack
aljimenez May 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/test/js/TestRunner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@
node.parent.results[testName] = {
result: failed ? "fail" : "pass",
message: error ? error.getMessage() : "Test passed",
error: error,
type: "test",
name: testName,
duration: duration
Expand Down
2 changes: 1 addition & 1 deletion src/test/js/YTestWrapAfter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ if (!YUI.YUITest) {
break;

case this.TEST_FAIL_EVENT:
message = event.testName + ": failed.\n" + event.error.getMessage();
message = event.testName + ": failed.\n" + event.error.stack;
Copy link
Contributor Author

@aljimenez aljimenez May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is much more useful to see the stack, when trying to fix failing tests.

messageType = "fail";
Copy link
Contributor Author

@aljimenez aljimenez May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the messageType be "error", such that Y.log prints the exception in red? That would make the exception easier to spot.

break;

Expand Down