Skip to content
This repository was archived by the owner on May 7, 2025. It is now read-only.

Comments

Fix empty arguments handling in OpenAI tool calls#14

Merged
yukinagae merged 1 commit intoyukinagae:mainfrom
habiliai:fix/empty-tool-request
Apr 1, 2025
Merged

Fix empty arguments handling in OpenAI tool calls#14
yukinagae merged 1 commit intoyukinagae:mainfrom
habiliai:fix/empty-tool-request

Conversation

@jcooky
Copy link
Contributor

@jcooky jcooky commented Apr 1, 2025

I discovered a bug where OpenAI generates text when genkit is called for a toolRequest with empty arguments. Instead, it should be called with {} as its argument.

Copy link
Owner

@yukinagae yukinagae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jcooky jcooky force-pushed the fix/empty-tool-request branch from 176cfd7 to fa82994 Compare April 1, 2025 09:16
@yukinagae yukinagae merged commit d191421 into yukinagae:main Apr 1, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants