Fix: Migration Autodetector class mismatch errors with dynamic command inheritance#1
Merged
Fix: Migration Autodetector class mismatch errors with dynamic command inheritance#1
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before continue to read this PR description first get initial context from this public PR.
What We Tried First (in the public PR)
Why It Failed
Django loads management commands from
INSTALLED_APPSin order. The first app providing a command wins, later apps with the same command are ignored.However:
django_linear_migrationsmakemigrations command module overridesdjango_pgviewsmakemigrations command module. Django seesdjango_linear_migrationsprovides makemigrations first and uses that.django_pgviewscommand implementation never even imports or runs andPGViewsAutodetectorclass modification to the original command is never applied.Our Solution
Why This Works
break→continue: Now our lookup skipsdjango_pgviewsbut continues checking apps after us inINSTALLED_APPSdjango_linear_migrations: When we iterate through apps, we hitdjango_linear_migrations(after us) and successfully import its command classdjango_linear_migrations's command, which inherits from Django's, preserving both:PGViewsAutodetector(from us)max_migration.txttracking (from django-linear-migrations)The Risk
Normally, apps later in
INSTALLED_APPSoverride earlier ones. Withdjango_linear_migrationsafterdjango_pgviews, ifdjango_linear_migrationsprovided bothmakemigrationsandmigratecommands, it would override ours completely and break pgviews.Why It's Safe
django_linear_migrationsonly providesmakemigrationscommand (notmigrate). Since Django's command loading sees our commands are already loaded anddjango_linear_migrationsdoesn't override all of them, our commands remain active while successfully inheriting from theirs.The Comment Explains It
We're essentially saying: "Load us first so we control the final commands, but we'll look ahead and inherit from apps that come after us."