Relax aten.to restriction (pytorch#142420)

Summary:

if we have a.to(b), and b has a different dtype with a, then it must be a copy. In this case, we do not need to freeze the tensor. Instead, we use torch.ops.aten._assert_tensor_metadata.default to ensure that a must not have the same dtype as b.


We need to remove ` torch.ops.aten._assert_tensor_metadata.default` for executorch. Update to pin to include pytorch/executorch#7277.

Test Plan:
```
buck2 run 'fbcode//mode/dev-nosan' fbcode//caffe2/test:test_export  -- -r  test_float_conversion
buck2 run 'fbcode//mode/dev-nosan' fbcode//caffe2/test:test_export  -- -r  test_device_to_mutation_float

ADD_NEW_STABILITY_CONFIGS=true  buck2 run 'fbcode//mode/opt' fbcode//aps_models/ads/modules/module_stability_tests/ctr_cvr_task_arch_stability_tests:inference_stability_tests

buck2 run 'fbcode//mode/dev-nosan' fbcode//deeplearning/aot_inductor/cpu/test:cpu_lowering_utils_test

buck2 run 'fbcode//mode/dev-nosan' //executorch/exir/tests:test_memory_format_ops_pass

buck test aps_models/ads/modules/module_stability_tests/histogram_binning_calibration_tests:calibration_by_feature_stability_test -- --env OVERRIDE_IR_CONFIGS=true

buck test aps_models/ads/modules/module_stability_tests/histogram_binning_calibration_tests:calibration_stability_test -- test_stability_config --env OVERRIDE_IR_CONFIGS=true

buck2 test 'fbcode//mode/opt' fbcode//aps_models/ads/modules/module_stability_tests/soft_max_loss_with_class_weights:stability_tests -- test_stability_config --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/loss_stability_tests:distillation_stability_tests -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/loss_stability_tests:stability_tests - aps_models.ads.modules.module_stability_tests.loss_stability_tests.ctr_cvr_logistic_regression_loss_stability_test.CtrCvrLogisticRegressionLossStabilityTest: test_cider_loss -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/feature_perturbation_stability_tests:sparse_feature_perturbation_test  -- --env OVERRIDE_IR_CONFIGS=true

 buck2 test fbcode//aps_models/ads/modules/module_stability_tests/ctr_cvr_task_arch_stability_tests:train_stability_tests   -- --env OVERRIDE_IR_CONFIGS=true

 buck2 test fbcode//aps_models/ads/modules/module_stability_tests/ctr_cvr_task_arch_stability_tests:inference_stability_tests   -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/ctr_cvr_task_arch_stability_tests:histogram_binning_stability_test    -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/aggregator_stability_tests:replicate_aggregator_stability_test     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/aggregator_stability_tests:label_aggregator_stability_test     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/aggregator_stability_tests:dral_aggregator_stability_test     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/module_stability_tests/adjust_task_weight_stability_tests:task_weight_stability_test     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/loss_modules/module_stability_tests/cider_stability_tests:stability_tests     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/py2pt/calibration/module_stability_tests/histogram_binning_calibration_stability_tests:stability_tests     -- --env OVERRIDE_IR_CONFIGS=true

buck2 test fbcode//aps_models/ads/modules/py2pt/calibration/module_stability_tests/histogram_binning_calibration_by_feature_stability_tests:stability_tests     -- --env OVERRIDE_IR_CONFIGS=true
```

Reviewed By: bdhirsh, shruthign

Differential Revision: D66988295

Author: yushangdi

.ci/docker/ci_commit_pins/executorch.txt

@@ -1 +1 @@
-6f638937d64e3396793956d75ee3e14802022745
+5b6d35b156067d47b0a89aa788c645b8320d8d3d

test/export/test_export.py

@@ -4684,6 +4684,29 @@ def forward(self, x):
         for op in ops:
             self.assertIn(op, (torch.ops.aten._to_copy.default,))
 
+    def test_float_conversion_from_int(self):
+        class Module(torch.nn.Module):
+            def forward(self, x):
+                return x.float()
+
+        ep = export(Module(), (torch.tensor(1, dtype=torch.int32),)).run_decompositions(
+            {}
+        )
+        ops = []
+        for node in ep.graph.nodes:
+            if node.op == "call_function":
+                ops.append(node.target)
+        self.assertGreater(len(ops), 0)
+        self.assertIn(torch.ops.aten._to_copy.default, ops)
+        self.assertIn(torch.ops.aten._assert_tensor_metadata.default, ops)
+
+        self.assertEqual(ep.module()(torch.tensor(1, dtype=torch.int32)), 1)
+
+        # Raises error because the input dtype is not the same as the input
+        # tensor when exporting.
+        with self.assertRaisesRegex(RuntimeError, "Tensor dtype mismatch!"):
+            ep.module()(torch.tensor(1, dtype=torch.float32))
+
     def test_device_to_mutation_float(self):
         class Module(torch.nn.Module):
             def forward(self, x):

torch/_subclasses/functional_tensor.py

@@ -535,7 +535,27 @@ def unwrap(x):
                             torch.ops.aten.dropout.default,
                             torch.ops.aten._to_copy.default,
                         ):
-                            torch._freeze_functional_tensor(outs_unwrapped)  # type: ignore[attr-defined]
+
+                            def must_copy():
+                                """
+                                Return True if the output of the op must be copied, not an alias
+                                """
+                                # output dtype is different from input
+                                return (
+                                    func == torch.ops.aten._to_copy.default
+                                    and "dtype" in kwargs
+                                    and kwargs["dtype"] != args_unwrapped[0].dtype
+                                )
+
+                            if must_copy():
+                                # We can further relax to args_unwrapped[0] != kwargs["dtype"], but I don't think
+                                # we have an aten op for that.
+                                torch.ops.aten._assert_tensor_metadata.default(
+                                    torch._from_functional_tensor(args_unwrapped[0]),
+                                    dtype=args_unwrapped[0].dtype,
+                                )
+                            else:
+                                torch._freeze_functional_tensor(outs_unwrapped)  # type: ignore[attr-defined]
                     outs_wrapped = pytree.tree_map_only(
                         torch.Tensor, wrap, outs_unwrapped
                     )