Skip to content

feat: Support for asynchronous getLoadContext #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2024
Merged

feat: Support for asynchronous getLoadContext #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150bfd1
Support for asynchronous `getLoadContext`
ogadra Nov 15, 2024
37cda75
check `remixContext` is promise or not
yusukebe Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const handle = (userApp?: Hono, options?: Options) => {
const args = createGetLoadContextArgs(c)

const remixContext = getLoadContext(args)
return handler(c.req.raw, remixContext)
return handler(c.req.raw, remixContext instanceof Promise ? await remixContext : remixContext)
})

return app
Expand Down
4 changes: 2 additions & 2 deletions src/remix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ export type GetLoadContext = (args: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
cloudflare: any
}
}) => AppLoadContext
}) => AppLoadContext | Promise<AppLoadContext>

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export const defaultGetLoadContext = ({ context }: any) => {
export const defaultGetLoadContext = ({ context }: any): AppLoadContext => {
return {
...context,
}
Expand Down