feat: add an example for cloudflare-workers #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogadra
changed the title
ogadra
commented
Nov 20, 2024
| }>() | ||
|
|
||
| app.use(async(c, next) => { | ||
| c.set('hono-context', 'hono-context') |
Contributor
Author
There was a problem hiding this comment.
I need to change the variable's name and value.
Owner
There was a problem hiding this comment.
I think it's better to use the same names with the Pages example: https://github.com/yusukebe/hono-remix-adapter/pull/24/files#diff-1a16d957977e7aaf27b0228dd216f0d8e30696f730d89b6d0d03c1c45fc3babbR14
ogadra
changed the title
ogadra
commented
Nov 20, 2024
Comment on lines
4
to
11
| const app = new Hono<{ | ||
| Bindings: { | ||
| MY_VAR: string | ||
| } | ||
| }, | ||
| Variables: { | ||
| 'MY_VAR_IN_VARIABLES': string | ||
| }, | ||
| }>() |
Contributor
Author
There was a problem hiding this comment.
I think we can use Env imported from load-context.ts, but I didn't change it because I wasn't sure if I was allowed to.
Suggested change
| const app = new Hono<{ | |
| Bindings: { | |
| MY_VAR: string | |
| } | |
| }, | |
| Variables: { | |
| 'MY_VAR_IN_VARIABLES': string | |
| }, | |
| }>() | |
| + import type { Env } from '../load-context' | |
| + const app = new Hono<Env>() |
If I change it, I also need to update cloudflare-pages.
ogadra
changed the title
Owner
Contributor
Author
Owner
|
@ogadra Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #24
Hello.
I added an example of #24 using Cloudflare Workers.
#24 (comment)
Screenshot