-
Notifications
You must be signed in to change notification settings - Fork 16
fix: escape vite asset import suffixes #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c799af0 to
cb85414
Compare
|
Thanks, I checked this out locally and I still see the 404 in the example you updated. |
Hmm, it works for me. I look more into it |
cb85414 to
28e9b2d
Compare
@john-griffin could you give it another try? |
|
Still a 404 with that pattern. I'm running via the |
shoot! I'll take a deeper look at this over the weekend |
Add the regix to exclude all vite asset import suffixes, might be better done in the @hono/vite-dev-server, but this fixes the issue for now
28e9b2d to
f309859
Compare
|
So
turns out I was testing with |
|
Thanks, that pattern is now working, imports are being returned with a 200 👍 |
|
Hey @barakcodes Thank you for fixing. I've added the test for this change. |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Looks good! Let's land it. |
Add the regex to exclude all vite asset import suffixes, might be better done in the @hono/vite-dev-server(maybe), but this fixes the issue for now
Rel #44