Skip to content

Fix React Router v7 Suspense streaming support #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix React Router v7 Suspense streaming support #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,15 @@ export const handle = (userApp?: Hono, options?: Options) => {
const args = createGetLoadContextArgs(c)

const reactRouterContext = getLoadContext(args)
return handler(
c.req.raw,
reactRouterContext instanceof Promise ? await reactRouterContext : reactRouterContext
)
const resolvedContext = reactRouterContext instanceof Promise ? await reactRouterContext : reactRouterContext

const response = await handler(c.req.raw, resolvedContext)

if (response.headers.get('content-type')?.includes('text/html')) {
response.headers.set('transfer-encoding', 'chunked')
Copy link
Owner

@yusukebe yusukebe Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good design if we set transfering-encoding: chunked for all HTML responses.

Copy link
Author

@azami azami Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this fix was quite hasty. Since it doesn't seem to be a straightforward fix, I will log an issue for it at this time.

}

return response
})

return app
Expand Down