Disable OpenMP for kNN and include missing headers#1
Open
iota97 wants to merge 1 commit intoyutanoma:mainfrom
Open
Disable OpenMP for kNN and include missing headers#1iota97 wants to merge 1 commit intoyutanoma:mainfrom
iota97 wants to merge 1 commit intoyutanoma:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congratulations on this excellent project, and thank you for making the code publicly available.
While testing the code on Ubuntu, I noticed that the medial axis computation was taking several seconds per iteration. The issue appears to be caused by each kNN query being parallelized. This behavior only occurs when OpenMP is enabled, so it may not have been visible on systems without OpenMP support.
After disabling this parallelization, I was able to reproduce the runtime reported in the paper. I also included a few missing header files required for successful compilation on Ubuntu.