Skip to content

Fix sonar issue s1155 'Collection.isEmpty()' should be used to test for emptiness #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlerbsc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sonar issue s1155 'Collection.isEmpty()' should be used to test for emptiness #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sorm4j/src/main/java/org/nkjmlab/sorm4j/extension/h2/commands/ScriptSql.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ public ScriptSql build() {
}
}

if (tables.size() != 0) {
if (!tables.isEmpty()) {
ret.add("table");
ret.add(String.join(",", tables));
}
if (schemas.size() != 0) {
if (!schemas.isEmpty()) {
ret.add("schema");
ret.add(String.join(",", schemas));
}
Expand Down
2 changes: 1 addition & 1 deletion sorm4j/src/main/java/org/nkjmlab/sorm4j/internal/context/logging/LogContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public LogContextImpl(
Supplier<SormLogger> loggerSupplier, Set<LogContext.Category> enabledCategories) {
this.loggerSupplier = loggerSupplier != null ? loggerSupplier : getDefaultLoggerSupplier();
this.enabledCategories =
enabledCategories.size() == 0 ? Collections.emptySet() : EnumSet.copyOf(enabledCategories);
enabledCategories.isEmpty() ? Collections.emptySet() : EnumSet.copyOf(enabledCategories);
}

public static Supplier<SormLogger> getDefaultLoggerSupplier() {
Expand Down
4 changes: 2 additions & 2 deletions sorm4j/src/main/java/org/nkjmlab/sorm4j/table/definition/TableDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ private static String createPrimaryKeyConstraint(String[] primaryKeys) {
}

private static String createUniqueConstraint(List<String[]> uniqueColumnPairs) {
return (uniqueColumnPairs == null || uniqueColumnPairs.size() == 0)
return (uniqueColumnPairs == null || uniqueColumnPairs.isEmpty())
? ""
: ", "
+ String.join(
Expand All @@ -324,7 +324,7 @@ private static String createUniqueConstraint(List<String[]> uniqueColumnPairs) {
}

private static String createCheckConstraint(List<String> checkConditions) {
return (checkConditions == null || checkConditions.size() == 0)
return (checkConditions == null || checkConditions.isEmpty())
? ""
: ", "
+ String.join(
Expand Down