-
Notifications
You must be signed in to change notification settings - Fork 0
revert: Update .pre-commit-config.yaml #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yxtay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a specific configuration change in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a change in .pre-commit-config.yaml by removing the types specification for the yamlfmt hook. This change is risky because it might cause the yamlfmt hook to run on all files, not just YAML files, which could break the pre-commit validation. I've added a comment suggesting to keep the explicit types configuration to ensure the hook behaves as expected.
| - repo: https://github.com/google/yamlfmt | ||
| rev: v0.19.0 | ||
| hooks: | ||
| - id: yamlfmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing types: [yaml] could cause the yamlfmt hook to run on all files, as pre-commit's default behavior is to target all files (types: [file]) if not specified otherwise by the hook. This would likely lead to errors on non-YAML files and cause pre-commit checks to fail. To ensure stability, it's safer to explicitly define the file types the hook should run on.
- id: yamlfmt
types: [yaml]|
KICS version: v2.1.14 Queries Results
|








No description provided.