Quality: Broken optional dependency handling for PyTorch#660
Open
tuanaiseo wants to merge 1 commit intoyzhao062:masterfrom
Open
Conversation
`pyod/models/gaal_base.py` tries to handle missing `torch` with a `try/except`, but immediately performs an unconditional `import torch` afterwards. If PyTorch is not installed, the module still crashes at import time, and the printed message is misleading. Affected files: gaal_base.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyod/models/gaal_base.pytries to handle missingtorchwith atry/except, but immediately performs an unconditionalimport torchafterwards. If PyTorch is not installed, the module still crashes at import time, and the printed message is misleading.Severity:
highFile:
pyod/models/gaal_base.pySolution
Remove the second unconditional
import torchand raise a clearImportErrorwith actionable installation guidance, or gate GAAL-specific code behind lazy imports.Changes
pyod/models/gaal_base.py(modified)Testing