fix(tests): correct mock paths and context type in test_generators#319
Open
ota2000 wants to merge 1 commit intoz3z1ma:mainfrom
Open
fix(tests): correct mock paths and context type in test_generators#319ota2000 wants to merge 1 commit intoz3z1ma:mainfrom
ota2000 wants to merge 1 commit intoz3z1ma:mainfrom
Conversation
- Pass yaml_context.project (DbtProjectContext) instead of yaml_context (YamlRefactorContext) to generator functions that expect DbtProjectContext - Fix mock.patch paths to target lazy import sources (dbt_core_interface.source_generator/staging_generator/doc_checker) instead of non-existent module-level attributes on dbt_osmosis.core.generators - Use tmp_path fixture instead of absolute /custom/staging path to avoid read-only filesystem errors
ota2000
force-pushed
the
ota2000/fix/test-generators-mock-paths
branch
from
3c0d8ea to
055ab5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 17 failing tests in
tests/core/test_generators.pycaused by two issues:Wrong context type: Tests passed
yaml_context(YamlRefactorContext) to generator functions that expectDbtProjectContext. Fixed by passingyaml_context.projectinstead.Invalid mock paths: Tests patched non-existent module-level attributes (e.g.,
dbt_osmosis.core.generators.SourceGenerator) for symbols that are lazy-imported inside functions. Fixed by targeting the actual import source modules:dbt_core_interface.source_generator.SourceGeneratordbt_core_interface.staging_generator.generate_staging_model_from_sourcedbt_core_interface.doc_checker.DocumentationCheckerFilesystem error: One test used
/custom/stagingas a path, causingOSError: Read-only file system. Fixed by using pytest'stmp_pathfixture.Result