fix: normalize column-level meta to config.meta for dbt 1.9+#324
Open
dtaniwaki wants to merge 1 commit intoz3z1ma:mainfrom
Open
fix: normalize column-level meta to config.meta for dbt 1.9+#324dtaniwaki wants to merge 1 commit intoz3z1ma:mainfrom
dtaniwaki wants to merge 1 commit intoz3z1ma:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this project! I'd appreciate your review on this small fix.
Problem
In dbt 1.9+, column-level
metashould be stored underconfig.metarather than as a top-levelmetaproperty (see dbt deprecations). The previous logic in_sync_doc_sectionwas doing the opposite — it was mergingconfig.metainto the top-levelmeta, which perpetuated the deprecated pattern.Solution
When dbt v1.10+ is detected and a column has a top-level
metadict, normalize it by moving it intoconfig.metaand removing the top-levelmetakey. This aligns the written YAML with dbt's recommendedstructure going forward.
Before:
After:
The change also removes the now-unnecessary bidirectional merge logic, simplifying the code significantly.