fix: case-insensitive Snowflake relation matching for catalog lookup in get_columns#325
Open
Felix313 wants to merge 1 commit intoz3z1ma:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snowflake catalog lookup failures caused by case-sensitive relation matching in
get_columns().Problem
When
target/catalog.jsoncontains uppercase relation names (common in Snowflake), dbt-osmosis may look up the same relation in lowercase and thus fails to match it.Example mismatch:
db.schema.table_namedb.schema.TABLE_NAMEThis prevents selecting the catalog entry and can lead to
ApproximateMatchError/ missing metadata behavior.Root Cause
Catalog matching used:
relation.matches(*c.key())which is case-sensitive for this Snowflake scenario.
Change
In
src/dbt_osmosis/core/introspection.py(get_columns()):Validation
Validated locally with:
`dbt-osmosis yaml refactor TABLE_NAME --catalog-path target\catalog.json
Result: catalog entry is found correctly despite case differences.
Related / Complementary
This PR is complementary to #322 .
get_columns().