fix(layout): add id2label to LayoutConfig and guard missing label_task_mapping#104
Open
Manitchahar wants to merge 2 commits intozai-org:mainfrom
Open
fix(layout): add id2label to LayoutConfig and guard missing label_task_mapping#104Manitchahar wants to merge 2 commits intozai-org:mainfrom
id2label to LayoutConfig and guard missing label_task_mapping#104Manitchahar wants to merge 2 commits intozai-org:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two layout-mode crashes when using custom config files by adding the missing id2label field to LayoutConfig and adding a guard for missing label_task_mapping in the layout detector initialization.
Changes:
- Added
id2labelfield toLayoutConfigto prevent AttributeError when readingconfig.id2label - Added guard in
layout_detector.pyto handle missinglabel_task_mappingwith a sensible default fallback
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| glmocr/config.py | Adds id2label field to LayoutConfig class definition |
| glmocr/layout/layout_detector.py | Adds guard to handle missing label_task_mapping with default fallback to text task type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes two layout-mode crashes when using custom config files:
LayoutConfigdid not declareid2label, butglmocr/layout/layout_detector.pyreads
config.id2label.id2label: Optional[Dict[Union[int, str], str]] = Noneinglmocr/config.py.layout_detector.pyassumedlabel_task_mappingis always present and called.items()on it.start()to fallback when missing:label_task_mapping = {"text": list(self.id2label.values())}Reproduction
id2labelandlabel_task_mapping.glmocr parse "image.png" --config custom.yamlAttributeErrorcrash. After: pipeline continues safely.Files changed
glmocr/config.py(+1 line)glmocr/layout/layout_detector.py(+5 lines)Notes
Scope is intentionally minimal (2 files only), with no behavior change unless those config fields are missing.