SOS Index and Call Rate #71

serenagrace · 2025-10-10T23:28:11Z

No description provided.

- Wild View now shows 4 slots, can be manually scrolled through to see SOS data - Improved SOS Support. Select "Caller Slot", then "Ally Slot" will be dynamically determined. - Display Caller PP remaining to avoid struggle! - Display whether Adrenaline Orb effect is active. - Supports both SM/USUM. - Tested on UM hardware + retail cartridge.

Fix off-by-one in SOS ally slot

- Added Submenu with Capture for tracking correction value for SOS ally slot - Hold X and press Right on the dPad to set the caller slot to the current ally slot - Hold X and press Up/Down on the dPad to increment/decrement caller slot manually - When a new Caller slot is set, the current chain length is saved as state in order to determine future ally slots (correction value) - Updated README with new controls - Added coloration to Egg Ready, Masuda, and Charm text

Added is-wild switch to draw_pkx

serenagrace · 2025-10-10T23:30:24Z

Should probably squash this but not sure how to from WebUI

zaksabeast

Should probably squash this but not sure how to from WebUI

I always merge + squash PRs into one commit to keep a clean history, so no worries about the number of commits. Pretty sure I've disabled the other merge settings to prevent accidents.

reader_core/src/gen7/call_rates.rs

reader_core/src/gen7/reader.rs

reader_core/src/gen7/draw.rs

reader_core/Cargo.toml

reader_core/src/gen7/reader.rs

serenagrace · 2025-10-13T15:28:46Z

Converted to draft, found SOS Seed hook address completely dysfunctional for SM, need to debug

- (hidden power and species are still in wild view)

serenagrace

Woohoo! Tested and working on Sun and UMoon retail, these are my final code changes for what I assume will be 0.8.2, not including review changes.

zaksabeast · 2025-10-17T11:34:17Z

reader_core/Cargo.toml

 [package]
 name = "pokereader"
-version = "0.8.0"
+version = "0.8.2"


Let's keep this at 0.8.0 – it can be incremented later.

zaksabeast · 2025-10-17T11:46:51Z

reader_core/src/draw.rs

+}
+
+pub fn draw_invalid_pkx() -> bool {
+    pnp::println!("No Data.");


I think showing a blank Pokemon might be more helpful.

Someone brand new to RNG who downloaded Reader for the first time and isn't sure if they set things up correctly might see "No Data." and be confused about if they did something wrong.

This message also doesn't have a way to self serve – there's no indication of how to fix the problem.

New people sometimes follow a YouTube video or a website tutorial with screenshots, and it's helpful if the video/images visually match what they're seeing.

Showing a blank PKX seems like it might be more intuitive for people.

I agree we can change the message itself, as "No Data" is a bit misleading... For Wild we can put "Not in Battle" or "Slot Empty" maybe? "Slot Empty" would also work well for Party, and "No Ally" would work for SOS.

Personally I believe that showing a blank Pkx really clutters the display when it doesn't need to-- especially for users who may X+Y lock the menu on Wild/SOS and getting in and out of several encounters. I agree that "No Data" is misleading, but I disagree that showing a blank Pkx is more intuitive, especially for things like cycling through party slots, it's a lot more convenient to see at a glance that there is nothing there.

reader_core/src/gen7/draw.rs

zaksabeast · 2025-10-17T11:56:15Z

reader_core/src/gen7/draw.rs

+        pnp::println!(color = RED, "Orb Not Active!");
+    }
+
+    pnp::println!("RNG Frame: {}", main_rng.advances());


Let's call this "Advance", not "Frame".

We've spent years trying to get away from the word "Frame" because it confuses people. When new people ask what a frame is, the answer is "it's when the rng advances", and they seem to understand that much more.

"Frame" made sense in gen 3 when the video frames were tied to the RNG advancement, but not anymore.

PokeReader only uses "frame" in reference to video frames, and RNG uses show "Advance".

zaksabeast · 2025-10-17T11:57:40Z

reader_core/src/gen7/frame.rs

+            pnp::println!("[X]/[Up]/[Down]:");
+            pnp::println!(" - Swap Caller");
+            pnp::println!("   Left/Right")


Is this still needed if we can auto-detect the Pokemon?

Yes. We can't fit all the information about the caller and the ally on one screen-- therefore we simplify things and just show the caller's call rate and remaining PP, while the Ally needs to show ability, nature, IVs, PID, etc. the ability to swap whether the caller on the left or is on the right is still important because especially for high SOS chains we certainly cannot guarantee the caller will be on the right.

Another goal of mine is to fit everything on the one page to reduce motions through the Pokereader plugin, because they can be annoying. The user needing to constantly scroll around to see the caller and the ally on separate pages would be really bothersome, which is also why we need to read two Pkx per frame as I mentioned above.

I'm fine with showing everything on one screen if we can keep it performant for 2ds/o3ds users.

If manual inputs are annoying, we should find a way to auto-assign caller vs. ally, (e.g. a game hook or logic like checking the current caller's hp is 0).

Ideally the user can view the info without needing to manually assign themselves.

zaksabeast · 2025-10-17T12:21:46Z

reader_core/src/rng/sfmt.rs

+        // sgrace: I think it's better to panic if this overflows,
+        //         As index > 624 should never naturally occur.


Let's remove this comment – the logic should prevents overflows.

zaksabeast · 2025-10-17T12:24:07Z

reader_core/src/rng/sfmt.rs

+        // sgrace: This one, however, can naturally overflow
+        //         in Sfmt64 at index = 0, so handle that.


Since the RNG is called several times per frame and needs to be performant, we should try to avoid the modulo.

Instead, let's add tests that will make sure we're not overflowing.

zaksabeast · 2025-10-17T12:26:30Z

reader_core/src/rng/sfmt.rs


 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct Sfmt {
+pub struct Sfmt32 {


Can you add tests to make sure the RNG is producing expected random numbers? The main things to check are producing rands before and after the shuffle.

We'll want confidence this works as expected if it's modified in the future.

I believe the existing SFMT tests (now under Sfmt64) exercise this behavior, no?

It's testing the u64s, but it'd still be good to make sure the u32s are expected in case we rewrite this in the future.

zaksabeast · 2025-10-17T12:27:01Z

reader_core/src/utils/sub_menu.rs

+    pub fn reset(&mut self) -> usize {
+        self.counter.reset()
+    }
+    pub fn increment(&mut self) -> usize {


Add a new line above this please.

zaksabeast · 2025-10-17T12:27:09Z

reader_core/src/utils/sub_menu.rs

        self.counter.value()
    }
+
+    pub fn _set(&mut self, value: usize) -> usize {


Let's remove this if it's unused.

serenagrace and others added 23 commits October 6, 2025 11:26

SOS slot changes

129bd69

Fixed line endings

3c273d1

0.7.5 Push

7dab31a

v0.8.1 Cleaned up some output ordering

46a6465

0.8.2 Added annotation to Caller Slot on SOS menu

b6128c4

Update reader.rs

4580e8f

Fix off-by-one in SOS ally slot

v0.8.3 - Refactored pp calls, updated brief IV drawing

112bdb0

Implemented Code Review changes

597918c

Added Help Menu with more control info

3fa9736

Added is-wild switch to draw_pkx

Fixed coloration for crystal and overflow in specific help

f99f49b

updated resource urls

751687b

Cleanup and corrected friendship

d77d6c0

Cleanup and corrected friendship

06cbcae

Cargo format and review round 3

8c5e49b

Remove dead code

821bae7

Updated format config

fe8c619

Added formatting target

72c6739

Enforced formatting

c62f1bd

Stabilize formatting

9bd354d

Added SOS Index, Caller Slot Call Rate

2db4b87

Merge branch 'main' into sos_index

2573574

zaksabeast requested changes Oct 11, 2025

View reviewed changes

serenagrace added 5 commits October 11, 2025 11:50

Fixed call rates to use species enum

b8f72e5

Split SFMT -> 32/64bit impls

483041a

Implemented RNG wrapper for SOS Sfmt32

eca5052

PP Coloration and Color Constants

7bc56fc

Added failbacks to drawpkx functions

9f337c2

serenagrace added 4 commits October 12, 2025 19:12

Gen7 Reader Slot/Side Refactor + SOS Track

a29c0a9

PP Coloration and Color Constants

e7055c6

Merge branch 'color-fix' into sos_index

55401e8

v0.8.2 Tested and Formatted

a2c0a54

serenagrace commented Oct 13, 2025

View reviewed changes

reader_core/src/gen7/reader.rs Outdated Show resolved Hide resolved

serenagrace added 2 commits October 12, 2025 21:29

More strict about hiding SOS Menu

5742799

Fix slot F & Cleanup constants

8cdb86b

serenagrace requested a review from zaksabeast October 13, 2025 02:31

Fixed SOS RNG Hook for SM

51e87a8

serenagrace marked this pull request as draft October 13, 2025 15:28

serenagrace added 6 commits October 13, 2025 18:25

Make draw_brief more brief

7e321b0

- (hidden power and species are still in wild view)

Add main rng advances to SOS

0a2ba6d

Cleanup constants and fix hooks

8343276

correct rng test suite and sfmt64 index bug

cffaa3e

SFMT Panic semantics

d801ed1

PP indicator correction

5efec80

serenagrace commented Oct 14, 2025

View reviewed changes

serenagrace marked this pull request as ready for review October 14, 2025 00:17

zaksabeast requested changes Oct 17, 2025

View reviewed changes

		// sgrace: I think it's better to panic if this overflows,
		// As index > 624 should never naturally occur.

		// sgrace: This one, however, can naturally overflow
		// in Sfmt64 at index = 0, so handle that.

SOS Index and Call Rate #71

Are you sure you want to change the base?

SOS Index and Call Rate #71

Uh oh!

Conversation

serenagrace commented Oct 10, 2025

Uh oh!

serenagrace commented Oct 10, 2025

Uh oh!

zaksabeast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serenagrace commented Oct 13, 2025

Uh oh!

serenagrace left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serenagrace Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaksabeast Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serenagrace Oct 17, 2025 •

edited

Loading

zaksabeast Oct 18, 2025 •

edited

Loading