Skip to content

Limit NotTriggerScaleUp to skipper-ingress pods #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikkeloscar wants to merge 1 commit into
base: zalando-cluster-autoscaler
Choose a base branch
from
Open

Limit NotTriggerScaleUp to skipper-ingress pods #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cluster-autoscaler/processors/status/eventing_scale_up_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,14 @@ func (p *EventingScaleUpStatusProcessor) Process(context *context.AutoscalingCon
consideredNodeGroupsMap := nodeGroupListToMapById(status.ConsideredNodeGroups)
if status.Result != ScaleUpSuccessful && status.Result != ScaleUpError {
for _, noScaleUpInfo := range status.PodsRemainUnschedulable {
context.Recorder.Event(noScaleUpInfo.Pod, apiv1.EventTypeNormal, "NotTriggerScaleUp",
fmt.Sprintf("pod didn't trigger scale-up (it wouldn't fit if a new node is"+
" added): %s", ReasonsMessage(noScaleUpInfo, consideredNodeGroupsMap)))
if noScaleUpInfo.Pod.Labels != nil && noScaleUpInfo.Pod.Labels["application"] == "skipper-ingress" && noScaleUpInfo.Pod.Labels["component"] == "ingress" {
// only emit NotTriggerScaleUp event for
// skipper-ingress pods as they are the only
// ones running on CA managed nodes in Zalando
context.Recorder.Event(noScaleUpInfo.Pod, apiv1.EventTypeNormal, "NotTriggerScaleUp",
fmt.Sprintf("pod didn't trigger scale-up (it wouldn't fit if a new node is"+
" added): %s", ReasonsMessage(noScaleUpInfo, consideredNodeGroupsMap)))
}
}
} else {
klog.V(4).Infof("Skipping event processing for unschedulable pods since there is a" +
Expand Down