Add and use pod labels to avoid having to query all pods from kubernetes#481
Draft
Add and use pod labels to avoid having to query all pods from kubernetes#481
Conversation
invalid team IDThe team ID in your You can follow this guideline for help. |
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
In `isPodOwnedByEDS()`, a new `context.Background()` is created instead of using the passed context. This bypasses cancellation propagation and could lead to hanging operations if the operator is shutting down during migration. Use the parent context throughout the call chain. Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Signed-off-by: Oliver Trosien <oliver.trosien@zalando.de>
Deployment ChecklistThis change falls under the deployment policy. 💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:
👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Implements pod labeling optimization for Kubernetes Elasticsearch operator to avoid querying all pods.
Issues
Key Changes:
es-operator-datasetlabeles-operator.zalando.org/pod-label-migration-completeto track migration statusImpact:
Types of Changes
Review
List of tasks the reviewer must do to review the PR
Deployment Notes