Implement a --log-level flag#852
Open
Adirael wants to merge 1 commit intozalando-incubator:masterfrom
Open
Conversation
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Signed-off-by: Angel Alonso <angel.alonso@automattic.com>
Adirael
force-pushed
the
feature/support-adjustable-log-level
branch
from
7797929 to
c5ba301
Compare
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Adirael
changed the title
szuecs
reviewed
Dec 11, 2025
| func (o AdapterServerOptions) RunCustomMetricsAdapterServer(stopCh <-chan struct{}) error { | ||
| level, logErr := log.ParseLevel(o.LogLevel) | ||
| if logErr != nil { | ||
| log.Warnf("Invalid log level '%s', defaulting to info", o.LogLevel) |
Member
There was a problem hiding this comment.
I think we should rather fail fast, so use: Fatalf or people will configure it to save money/Storage/.. and then do not check if it is running correctly.
Contributor
There was a problem hiding this comment.
I agree, let's just fail fast if this is set to a wrong value
szuecs
added
the
minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Add a
--log-levelflag (default level info) to allow making log output less verbose.Description
The default log level setting is very noisy when
kube-metrics-adapteris deployed on large clusters. This may lead to performance and monitoring issues where important logs are lost due to volume.Types of Changes
Review
List of tasks the reviewer must do to review the PR