Remove trailing quotes in custom-metrics-apiservice.yaml#876
Open
alexalex89 wants to merge 1 commit intozalando-incubator:masterfrom
Open
Remove trailing quotes in custom-metrics-apiservice.yaml#876alexalex89 wants to merge 1 commit intozalando-incubator:masterfrom
alexalex89 wants to merge 1 commit intozalando-incubator:masterfrom
Conversation
The trailing `""` after `{{- end}}` causes a YAML parse error when
rendering the Helm chart, breaking install/upgrade on v0.2.8.
Fixes zalando-incubator#875
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Contributor
|
Thanks @alexalex89 can you sign-off the commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
""after{{- end}}indocs/helm/templates/custom-metrics-apiservice.yamlwhich causes a YAML parse error, breaking Helm install/upgrade on v0.2.8Fixes #875
Test plan
Verified
helm template kube-metrics-adapter ./docs/helm/renders successfully after the fix.