Skip to content

Remove TopologyAwareHints Feature Flag #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Remove TopologyAwareHints Feature Flag #9580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cluster/config-defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,9 +945,6 @@ enable_default_sa: "false"
vm_dirty_background_bytes: "67108864"
vm_dirty_bytes: "134217728"

# Option to Enable FeatureGate TopologyAwareHints
enable_topology_aware_hints: "false"

# Enable FeatureGate HPAScaleToZero
enable_hpa_scale_to_zero: "true"

Expand Down
1 change: 0 additions & 1 deletion cluster/manifests/kube-proxy/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ data:
tcpEstablishedTimeout: 24h0m0s
enableProfiling: false
featureGates:
TopologyAwareHints: {{ .Cluster.ConfigItems.enable_topology_aware_hints }}
SizeMemoryBackedVolumes: {{ .Cluster.ConfigItems.enable_size_memory_backed_volumes }}
{{- if eq .Cluster.ConfigItems.enable_image_volumes "true" }}
ImageVolume: true
Expand Down
4 changes: 2 additions & 2 deletions cluster/node-pools/master-default/userdata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ write_files:
- "--oidc-username-prefix=okta:"
- --oidc-groups-claim=groups
- "--oidc-groups-prefix=okta:"
- --feature-gates=HPAScaleToZero={{ .Cluster.ConfigItems.enable_hpa_scale_to_zero }},StatefulSetAutoDeletePVC={{ .Cluster.ConfigItems.enable_statefulset_autodelete_pvc }},TopologyAwareHints={{ .Cluster.ConfigItems.enable_topology_aware_hints }},MaxUnavailableStatefulSet={{.Cluster.ConfigItems.max_unavailable_statefulset_enabled}},KMSv1=true{{if eq .Cluster.ConfigItems.enable_image_volumes "true"}},ImageVolume=true{{end}}
- --feature-gates=HPAScaleToZero={{ .Cluster.ConfigItems.enable_hpa_scale_to_zero }},StatefulSetAutoDeletePVC={{ .Cluster.ConfigItems.enable_statefulset_autodelete_pvc }},MaxUnavailableStatefulSet={{.Cluster.ConfigItems.max_unavailable_statefulset_enabled}},KMSv1=true{{if eq .Cluster.ConfigItems.enable_image_volumes "true"}},ImageVolume=true{{end}}
- --service-account-key-file=/etc/kubernetes/ssl/service-account-public-key.pem
- --service-account-signing-key-file=/etc/kubernetes/ssl/service-account-private-key.pem
- --service-account-issuer={{ .Cluster.APIServerURL }}
Expand Down Expand Up @@ -620,7 +620,7 @@ write_files:
- --root-ca-file=/etc/kubernetes/ssl/ca.pem
- --cloud-provider=external
- --cloud-config=/etc/kubernetes/cloud-config.ini
- --feature-gates=StatefulSetAutoDeletePVC={{ .Cluster.ConfigItems.enable_statefulset_autodelete_pvc }},TopologyAwareHints={{ .Cluster.ConfigItems.enable_topology_aware_hints }},MaxUnavailableStatefulSet={{.Cluster.ConfigItems.max_unavailable_statefulset_enabled}}{{if eq .Cluster.ConfigItems.enable_image_volumes "true"}},ImageVolume=true{{end}}
- --feature-gates=StatefulSetAutoDeletePVC={{ .Cluster.ConfigItems.enable_statefulset_autodelete_pvc }},MaxUnavailableStatefulSet={{.Cluster.ConfigItems.max_unavailable_statefulset_enabled}}{{if eq .Cluster.ConfigItems.enable_image_volumes "true"}},ImageVolume=true{{end}}
- --use-service-account-credentials=true
- --configure-cloud-routes=false
- --allocate-node-cidrs=true
Expand Down