Skipper ingress Redis scheduling annotations #9642
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
do-not-merge
minor
…ance type pased weights Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
skipper-ingress-scheduling-controls
branch
from
3919735 to
cff43bf
Compare
mikkeloscar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements scheduling annotations for skipper-ingress-redis such that a dedicated node pool is not needed, but it will land on dedicated nodes via dedicated scheduling annotation feature.
(Since kube-system currently is not covered by scheduling annotations, the annotation is not defined, but the nodeSelector/toleration which is normally injected by admission-controller, is defined manually)
The changes includes a few more optimizations:
karpenter.sh/do-not-disrupt: "true"which is the equivalent ofcluster-autoscaler.kubernetes.io/safe-to-evict: "false"for karpenter