Skip to content

FabricGateway: Add ValidatingAdmissionPolicy #9651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

MustafaSaber
Copy link
Member

@MustafaSaber MustafaSaber commented Jul 7, 2025

Enforce new FabricGateway using stacksets to use versioning

Enforce new FabricGateway using stacksets to use versioing

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@MustafaSaber MustafaSaber self-assigned this Jul 7, 2025
@MustafaSaber MustafaSaber added major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. do-not-merge labels Jul 7, 2025
@shyamz-22
Copy link

👍🏽

operations: ["CREATE"]
resources: ["fabricgateways"]
validations:
- expression: 'object.spec.exists(key, key == "x-external-service-provider") && object.spec["x-external-service-provider"].exists(key, key == "stackVersion")'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has macro doesn't really work with this naming convention, that's why I used exists

@MustafaSaber
Copy link
Member Author

MustafaSaber commented Jul 8, 2025

This will also block Fabrics without StackSet. Will check why.

Fixed.

@MustafaSaber
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants