Skip to content

Conversation

hesserp
Copy link
Contributor

@hesserp hesserp commented Feb 10, 2021

Add support for decimal type #43 and timestamp type #37

decimal type has optional parameters precision and range (spark default are 10 and 0).
example:

"decimal_field": {
  "type": "decimal",
  "precision": 38,
  "range": 18
}

when using a timestamp field you may provide a format on loading the data, e.g.

sparkSession.read.schema(schema).options(Map("timestampFormat" -> "yyyy-MM-dd HH:mm:ss")).json("path/to/data")

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (d5d8677) to head (08cae3c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   91.56%   93.06%   +1.50%     
==========================================
  Files           1        1              
  Lines          83      101      +18     
  Branches        1        1              
==========================================
+ Hits           76       94      +18     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zzeekk
Copy link

zzeekk commented Dec 25, 2021

Support of timestamp and decimal datatypes would be very interesting. Is there a plan to merge this PR?

Copy link

invalid team ID

The team ID in your .zappr.yaml file (in the default branch) does not appear
to be valid. Please, fix this before team ID checks will be added back into
ComPR's specification check.

(If this PR is already fixing this, ignore the warning. But preferably fix it
in a PR separate from other changes, as the merge build from this PR will
not give a compliant image.)

You can follow this guideline for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants