Improve forward feature #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
force-pushed
the
improve-forward
branch
3 times, most recently
from
d4e2eaf to
32c810c
Compare
mikkeloscar
changed the base branch from
master
to
stackset-locally-kubeconfig
mikkeloscar
force-pushed
the
improve-forward
branch
from
32c810c to
c90d6c0
Compare
mikkeloscar
changed the base branch from
stackset-locally-kubeconfig
to
master
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
improve-forward
branch
from
ded168d to
f9f9855
Compare
tcondeixa
approved these changes
Dec 19, 2025
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #716 to improve the feature
TrafficForward()to encapsulate the annotation check--enable-forward-support(defaultfalse) to conditionally enable the feature. If the flag is set tofalsethe annotation at stackset level will be ignored. This allows users to set the annotation on the target cluster, during migration, without it having an effect.