Draft: Add custom roundTripper to net.Client #3479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavivars
changed the title
Member
|
chat discussion https://gophers.slack.com/archives/C82Q5JNH5/p1745406971386959 |
Member
|
@xavivars sorry I didn't respond here, yet but I think it's fine to do it as you suggested. |
Contributor
Author
|
It was clear, it's just that I dropped this branch somewhere and will need to get back to it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early PR, to discuss the approach.
An alternative would be to allow for injecting an HTTP client. However, I prefer being able to do this because I do appreciate all the defaults net.Client and its Transport already have.
If you think functionality like this would be useful contributed upstream, these are the parts that are missing