Skip to content

feat: adding BGV mult#423

Open
titouantanguy wants to merge 17 commits intomainfrom
titouan/feat/bgv-mult
Open

feat: adding BGV mult#423
titouantanguy wants to merge 17 commits intomainfrom
titouan/feat/bgv-mult

Conversation

@titouantanguy
Copy link
Contributor

@titouantanguy titouantanguy commented Feb 17, 2026

Description of changes

Adds BGV multiplication.
Adds BGV bencharks.
Minor modifications of Docker setup and Makefile.toml to fix healthcheck and reduce a bit compile time by playing with features.

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@titouantanguy titouantanguy requested a review from a team as a code owner February 17, 2026 16:24
@cla-bot cla-bot bot added the cla-signed The CLA has been signed. label Feb 17, 2026
@titouantanguy titouantanguy changed the title chore: adding BGV mult feat: adding BGV mult Feb 17, 2026
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Consolidated Tests Results 2026-02-24 - 17:14:33

Test Results

passed 14 passed

Details

tests 14 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #563
pull-request feat: adding BGV mult link #423

test-reporter: Run #563

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
full_gen_tests_k8s_default_threshld_sequential_crs 32.7s
test_k8s_threshld_insecure 3m 11s
k8s_test_crs_uniqueness 32.7s
k8s_test_keygen_and_crs 3m 15s
k8s_test_keygen_uniqueness 8m 52s
full_gen_tests_k8s_default_threshld_sequential_crs 32.8s
test_k8s_threshld_insecure 3m 15s
k8s_test_crs_uniqueness 33.1s
k8s_test_keygen_and_crs 3m 13s
k8s_test_keygen_uniqueness 8m 57s
full_gen_tests_k8s_default_centralzd_sequential_crs 1.8s
test_k8s_centralzd_insecure 1m
full_gen_tests_default_k8s_centralized_sequential_crs 1.8s
k8s_test_centralized_insecure 1m 1s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions, overall it looks neat.

Copy link
Contributor

@kc1212 kc1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments, otherwise LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants