Conversation
Consolidated Tests Results 2026-02-25 - 18:50:15Test ResultsDetails
test-reporter: Run #597
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
There was a problem hiding this comment.
Did you run both make test-backward-compatibility and make generate-backward-compatibility-all?
The failure is a bit weird since it seems to be from some types that has gotten added to the run files with this PR.
Another issue is that some places the references still needs to be updated. Search for 0-13-1 and 0_13_1 and update accordingly
jot2re
left a comment
There was a problem hiding this comment.
Looks good!
Just a couple of minor inline comments.
I have a couple of more general comments as well:
- Not exactly this PR, but in backward-compatibility/generate-v0_13_0 should the tagged version be updated from
v0.13.0-rc.2to the most current release? - Could you also update backwards-compatibility.md since it talked about
--locked.
| ), | ||
| ( | ||
| kms_core_version_min: "0.13.0", | ||
| kms_core_version_min: "0.13.10", |
There was a problem hiding this comment.
It seems version 0.13.0 is removed from the .ron file.
| metadata: ReleasePCRValues(( | ||
| test_filename: "release_pcr_values", | ||
| state: 64, | ||
| )), |
There was a problem hiding this comment.
Also here it seems too much has been removed
There was a problem hiding this comment.
Not sure how to fix this. I ran make generate-backward-compatibility-all and that ran successfully.
I don't think this is related to any changes I made in this PR.
There was a problem hiding this comment.
Figured it out: this is a duplicate from line 177, and so are the other deleted entries.
|
Updated the docs and removed mention of |
There was a problem hiding this comment.
Pull request overview
This PR bumps the workspace version on main to v0.13.10-rc.0, updates backward-compatibility tooling/data to reflect the new 0.13.10 naming, and refreshes dependencies/lockfiles (including a keccak bump mentioned in the description).
Changes:
- Bump workspace/package versions to
0.13.10-rc.0and updateCargo.lock(includingkeccak0.1.6). - Add a new backward-compatibility generator crate for
v0.13.10and update docs/Makefile targets accordingly. - Update backward-compatibility metadata + LFS-tracked datasets to include
0.13.10(and clean up prior0.13.1artifacts).
Reviewed changes
Copilot reviewed 23 out of 83 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/developer/backward_compatibility.md | Updates backward-compatibility documentation and adds v0.13.0/v0.13.10 generator references. |
| backward-compatibility/generate-v0.13.10/src/main.rs | Switches generator entrypoint to V0_13_10. |
| backward-compatibility/generate-v0.13.10/src/lib.rs | Adds crate module exports for the new generator crate. |
| backward-compatibility/generate-v0.13.10/src/generate.rs | Adds shared generator utilities/traits/macros for v0.13.10 generation. |
| backward-compatibility/generate-v0.13.10/src/data_0_13.rs | Updates generator implementation to use kms_0_13_10/threshold_fhe_0_13_10 types and version constant 0.13.10. |
| backward-compatibility/generate-v0.13.10/Cargo.toml | Introduces the v0.13.10 generator crate manifest and pins KMS deps to a git rev. |
| backward-compatibility/generate-v0.13.10/Cargo.lock | Captures the dependency graph for the v0.13.10 generator crate. |
| backward-compatibility/generate-v0.13.0/Cargo.toml | Updates the v0.13.0 generator manifest pins/versions (now pointing at v0.13.3). |
| backward-compatibility/generate-v0.13.0/Cargo.lock | Updates the dependency graph for the v0.13.0 generator crate (now resolving 0.13.3). |
| backward-compatibility/generate-v0.11.1/Cargo.lock | Updates generator lockfile to match backward-compatibility crate version bump. |
| backward-compatibility/generate-v0.11.0/Cargo.lock | Updates generator lockfile to match backward-compatibility crate version bump. |
| backward-compatibility/data/threshold-fhe.ron | Updates/cleans threshold-fhe testcase metadata and adds 0.13.10 entries. |
| backward-compatibility/data/kms.ron | Updates/cleans KMS testcase metadata and adds 0.13.10 entries. |
| backward-compatibility/data/kms-grpc.ron | Updates/cleans kms-grpc testcase metadata and adds 0.13.10 entries. |
| backward-compatibility/data/0_13_10/threshold-fhe/share_64.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/share_128.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/release_pcr_values.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/prss_setup_rpoly_64.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/prss_setup_rpoly_128.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/prss_set_64.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/prss_set_128.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/prf_key.bcode | Adds 0.13.10 threshold-fhe dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/auxiliary_prss_set_64/legacy_prss_set_64.bcode | Adds 0.13.10 threshold-fhe auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/threshold-fhe/auxiliary_prss_set_128/legacy_prss_set_128.bcode | Adds 0.13.10 threshold-fhe auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/unified_signcryption.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/unified_ciphertext.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/typed_plaintext.bincode | Adds 0.13.10 KMS typed_plaintext dataset (inline binary). |
| backward-compatibility/data/0_13_10/kms/threshold_fhe_keys.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/software_version.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/signcryption_payload.bincode | Adds 0.13.10 KMS signcryption payload dataset (inline binary). |
| backward-compatibility/data/0_13_10/kms/signcryption_key.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/recovery_material.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/public_sig_key.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/prss_setup_combined.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/private_sig_key.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/operator_backup_output.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/node_info.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/kms_fhe_key_handles.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/key_gen_metadata.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/internal_recovery_request.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/internal_custodian_setup_message.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/internal_custodian_recovery_output.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/internal_cus_context.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/hybrid_kem_ct.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/designcryption_key.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/crs_gen_metadata.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/context_info.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/backup_ciphertext.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_unified_ciphertext/hybrid_kem_ct_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_threshold_fhe_keys/sns_key.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_threshold_fhe_keys/private_key_set.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_threshold_fhe_keys/integer_server_key.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_threshold_fhe_keys/info.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_threshold_fhe_keys/decompression_key.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_recovery_material/internal_cus_context_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_prss_setup_combined/prss_setup_64.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_prss_setup_combined/prss_setup_128.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_kms_fhe_key_handles/sig_key_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_kms_fhe_key_handles/server_key_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_kms_fhe_key_handles/public_key_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_kms_fhe_key_handles/decompression_key.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_kms_fhe_key_handles/client_key_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_key_gen_metadata/legacy_key_gen_metadata.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_internal_cus_context/unified_enc_key_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_crs_gen_metadata/legacy_crs_gen_metadata.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/auxiliary_backup_ciphertext/unified_ciphertext_handle.bcode | Adds 0.13.10 KMS auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms/app_key_blob.bcode | Adds 0.13.10 KMS dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms-grpc/signed_pub_data_handle_internal.bcode | Adds 0.13.10 kms-grpc dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms-grpc/pub_data_type.bcode | Adds 0.13.10 kms-grpc dataset (LFS pointer). |
| backward-compatibility/data/0_13_10/kms-grpc/priv_data_type.bcode | Adds 0.13.10 kms-grpc dataset (LFS pointer). |
| backward-compatibility/data/0_13_1/kms/threshold_fhe_keys.bcode | Removes obsolete 0.13.1 dataset (LFS pointer). |
| backward-compatibility/data/0_13_1/kms/key_gen_metadata.bcode | Removes obsolete 0.13.1 dataset (LFS pointer). |
| backward-compatibility/data/0_13_1/kms/internal_custodian_setup_message.bcode | Removes obsolete 0.13.1 dataset (LFS pointer). |
| backward-compatibility/data/0_13_1/kms/auxiliary_threshold_fhe_keys/private_key_set.bcode | Removes obsolete 0.13.1 auxiliary dataset (LFS pointer). |
| backward-compatibility/data/0_13_0/kms/internal_custodian_setup_message.bcode | Updates 0.13.0 dataset (LFS pointer OID change). |
| backward-compatibility/data/0_13_0/kms-grpc/public_key_type.bcode | Removes obsolete public_key_type dataset file. |
| backward-compatibility/data/0_11_1/kms-grpc/public_key_type.bcode | Removes obsolete public_key_type dataset file. |
| backward-compatibility/data/0_11_0/kms-grpc/public_key_type.bcode | Removes obsolete public_key_type dataset file. |
| backward-compatibility/Cargo.toml | Bumps backward-compatibility crate version to 0.13.10. |
| Makefile | Updates compose targets and backward-compatibility generation/test targets. |
| Cargo.toml | Bumps workspace version to 0.13.10-rc.0 and excludes the new generator crate. |
| Cargo.lock | Updates lockfile versions and bumps keccak to 0.1.6. |
| .gitignore | Ignores backup_vault and proptest-regressions. |
Comments suppressed due to low confidence (2)
backward-compatibility/generate-v0.13.10/Cargo.toml:22
- The comment about “temporarily removing the
--lockedflag” is now out of sync with the Makefile target (it currently runs without--locked). Either reintroduce--lockedfor reproducible generation, or update this comment so it describes the current workflow and when/why lockfiles should be updated.
backward-compatibility/generate-v0.13.10/Cargo.toml:22 - Typo in comment: “verison” -> “version”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of changes
This PR sets the version on
maintov0.13.10-rc.0to clearly distinguish it from thev0.13.0release we have made a few days ago. Hotfixes on the previousv0.13.0release will be calledv0.13.1up tov0.13.9. This should be sufficient given that we plan to release v0.13.10 in ~4 weeks.We are abusing semantic versioning here to some extent, but for a reason: we like to sync up the version used by
fhevmandkms, so we are staying atv0.13.xuntil fhevm has caught up in mid Q2.This PR also fixes a security issue by bumping
keccakto the newest version.It also renames the backward compatibility tests to match the v0.13.10 naming.
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.