Skip to content

Kc1212/feat/2887/compressed keygen from existing secret tests#438

Draft
kc1212 wants to merge 2 commits intomainfrom
kc1212/feat/2887/compressed-keygen-from-existing-secret-tests
Draft

Kc1212/feat/2887/compressed keygen from existing secret tests#438
kc1212 wants to merge 2 commits intomainfrom
kc1212/feat/2887/compressed-keygen-from-existing-secret-tests

Conversation

@kc1212
Copy link
Contributor

@kc1212 kc1212 commented Feb 24, 2026

Description of changes

Tested manually also with

cargo run -- -f config/client_local_threshold.toml preproc-key-gen
# save the first preproc ID as PREPROC1
cargo run -- -f config/client_local_threshold.toml key-gen -i $PREPROC1
# save the first key ID as KEYID1

cargo run -- -f config/client_local_threshold.toml preproc-key-gen --from-existing-shares
# save the second preproc ID as PREPROC2
cargo run -- -f config/client_local_threshold.toml key-gen -i $PREPROC2 --compressed # note that we use compressed
# save the second key ID as KEYID2

# now we can run ddec
cargo run -- -f config/client_local_threshold.toml public-decrypt from-args -d euint64 -k ${KEYID2} --num-requests 1 --batch-size 1 --to-encrypt ff

# one can also verify that the types in the public/private storage. but it's not easy to check that the binaries are partially the same in the shares

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@kc1212 kc1212 self-assigned this Feb 24, 2026
@kc1212 kc1212 requested a review from a team as a code owner February 24, 2026 16:08
@cla-bot cla-bot bot added the cla-signed The CLA has been signed. label Feb 24, 2026
@kc1212 kc1212 marked this pull request as draft February 24, 2026 16:08
@kc1212 kc1212 force-pushed the kc1212/feat/2887/compressed-keygen-from-existing-secret-tests branch from f20d77d to 3ffd506 Compare February 25, 2026 09:25
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Consolidated Tests Results 2026-02-25 - 15:59:48

Test Results

passed 14 passed

Details

tests 14 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #589
pull-request Kc1212/feat/2887/compressed keygen from existing secret tests link #438

test-reporter: Run #589

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
full_gen_tests_k8s_default_threshld_sequential_crs 33.3s
test_k8s_threshld_insecure 3m 14s
k8s_test_crs_uniqueness 33.2s
k8s_test_keygen_and_crs 3m 14s
k8s_test_keygen_uniqueness 8m 53s
full_gen_tests_k8s_default_centralzd_sequential_crs 1.8s
test_k8s_centralzd_insecure 2m 58s
full_gen_tests_default_k8s_centralized_sequential_crs 1.8s
k8s_test_centralized_insecure 1m 1s
full_gen_tests_k8s_default_threshld_sequential_crs 32.8s
test_k8s_threshld_insecure 3m 15s
k8s_test_crs_uniqueness 33.1s
k8s_test_keygen_and_crs 3m 13s
k8s_test_keygen_uniqueness 8m 57s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@kc1212 kc1212 force-pushed the kc1212/feat/2887/compressed-keygen-from-existing-secret-tests branch from 3ffd506 to cdf6375 Compare February 25, 2026 14:33
@kc1212 kc1212 force-pushed the kc1212/feat/2887/compressed-keygen-from-existing-secret-tests branch from cdf6375 to 3770c89 Compare February 25, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant