Open
Conversation
Contributor
nsarlin-zama
left a comment
There was a problem hiding this comment.
Looks nicely handled! Just a small typo
@nsarlin-zama reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: 4 of 11 files reviewed, 1 unresolved discussion (waiting on SouchonTheo and tmontaigu).
tfhe/src/high_level_api/xof_key_set/mod.rs line 61 at r1 (raw file):
// 11) SNS Compression Key /// Holds an [XofSeed] and the byte at which the random generator should start.
Small typo:
Code snippet:
/// Holds a [XofSeed] and the byte at which the random generator should start.Add an enum that allows to represent where the CSPRNG for the CompressedXofKeySet must start. This is to accommodate for the csprng bug that was fixed in tfhe-csprng 0.9 to still be able to load 1.5.4 (csprng 0.8.1) data correctly Defaults to first byte, backward_compatibility handles old data that was versioned with it.
5afd5b3 to
d4ccd24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an enum that allows to represent where the CSPRNG for the
CompressedXofKeySet must start. This is to accommodate for the csprng bug
that was fixed in tfhe-csprng 0.9 to still be able to load 1.5.4 (csprng
0.8.1) data correctly
Defaults to first byte, backward_compatibility handles old data that was
versioned with it.
This change is