Skip to content

Tm/xof compat 1 6 5#3399

Open
tmontaigu wants to merge 2 commits intomainfrom
tm/xof-compat-1-6-5
Open

Tm/xof compat 1 6 5#3399
tmontaigu wants to merge 2 commits intomainfrom
tm/xof-compat-1-6-5

Conversation

@tmontaigu
Copy link
Contributor

@tmontaigu tmontaigu commented Mar 17, 2026

Add an enum that allows to represent where the CSPRNG for the
CompressedXofKeySet must start. This is to accommodate for the csprng bug
that was fixed in tfhe-csprng 0.9 to still be able to load 1.5.4 (csprng
0.8.1) data correctly

Defaults to first byte, backward_compatibility handles old data that was
versioned with it.


This change is Reviewable

@cla-bot cla-bot bot added the cla-signed label Mar 17, 2026
@tmontaigu tmontaigu marked this pull request as ready for review March 18, 2026 09:04
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicely handled! Just a small typo

@nsarlin-zama reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: 4 of 11 files reviewed, 1 unresolved discussion (waiting on SouchonTheo and tmontaigu).


tfhe/src/high_level_api/xof_key_set/mod.rs line 61 at r1 (raw file):

// 11) SNS Compression Key

/// Holds an [XofSeed] and the byte at which the random generator should start.

Small typo:

Code snippet:

/// Holds a [XofSeed] and the byte at which the random generator should start.

Add an enum that allows to represent where the CSPRNG for the
CompressedXofKeySet must start. This is to accommodate for the csprng bug
that was fixed in tfhe-csprng 0.9 to still be able to load 1.5.4 (csprng
0.8.1) data correctly

Defaults to first byte, backward_compatibility handles old data that was
versioned with it.
@tmontaigu tmontaigu force-pushed the tm/xof-compat-1-6-5 branch from 5afd5b3 to d4ccd24 Compare March 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants