[pull] master from apify:master#175
Merged
pull[bot] merged 3 commits intozanachka:masterfrom Feb 26, 2026
Merged
Conversation
At the moment lint-staged is installed but it is just dangling in repo and it is not used. Pre-commit hook runs `yarn format` on whole codebase instead of staged files. This also create state where after commit multiple files can be changed, usually followed by `lint:fix` commit (or similar) After this merged: - lint-staged will run biome --format only on staged files, automatically add changes to commit (if any) - as it not working on a whole repo, execution should be even faster
…#3434) In v3, `discoverValidSitemaps` could occasionally hang during initialization (before crawler startup), especially on proxy-heavy targets used by Website Content Crawler. Root cause: Discovery requests (`GET /robots.txt` and `HEAD` sitemap checks) used default `got-scraping` behavior. In this path, HTTP/2 + browser-header generation could become unstable and stall on some targets/proxy combinations. What changed: Updated `discoverValidSitemaps` internals in `packages/utils/src/internals/sitemap.ts`. Added dedicated discovery request options: - `http2: false` - `useHeaderGenerator: false` Applied these options consistently to: - robots.txt fetch - sitemap candidate `HEAD` checks Note: this PR intentionally keeps got-scraping since we’re on v3; this gives us a minimal, safer fix for the hang without replacing the HTTP stack or introducing broader regressions. Tested on local with patched `@crawlee/utils` Closes #3412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )