Merged
Conversation
Member
Author
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
psiinon
force-pushed
the
tweak/remove-clear
branch
from
fce4196 to
fe5a02a
Compare
kingthorin
approved these changes
Jan 23, 2025
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
tweak/remove-clear
branch
from
fe5a02a to
1bf436d
Compare
thc202
approved these changes
Jan 27, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Zest clear statements were not needed and caused problems.
I think they were originally there when the code handled
keydownevents, but now we are using thechangeevent and sending the whole field value, so it really doesn't matter if the user replaces existing text or not.Also added a few more tests :)