Update to Node 20 and fix TS errors#127
Merged
thc202 merged 1 commit intozaproxy:mainfrom Feb 13, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
psiinon
force-pushed
the
fix/ts
branch
2 times, most recently
from
a316236 to
e084798
Compare
Member
Author
|
OK, thats a good enough set of changes to merge 😁 Ready for review.. |
Member
|
I'm sure there's a process here and it isn't fun to deal with. however we should probably look at moving to 22 "soon" as 20 is already in maintenance mode (vs active dev).
|
kingthorin
approved these changes
Feb 13, 2025
Member
Author
|
One step at a time please! I tried to jump versions and it all went horribly wrong. |
kingthorin
approved these changes
Feb 13, 2025
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
thc202
approved these changes
Feb 13, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to newer node version, but trying one step at a time to see what fails...