Params Initial Relocation #6933
Conversation
|
Add-on loads and works as expected. Help doesn't work for some reason that I haven't been able to nail down. (I've compared vs spider and don't see the missing bit). I still need to address the DB bits. Turns out there were not images/icons in use. |
|
|
||
| public ExtensionParams2() { | ||
| super(NAME); | ||
| this.setOrder(59); |
There was a problem hiding this comment.
I bumped this to 59 vs core 58.
kingthorin
force-pushed
the
migrate-params
branch
2 times, most recently
from
77cd1e0 to
76933e1
Compare
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
kingthorin
force-pushed
the
migrate-params
branch
2 times, most recently
from
08eff9c to
08bfcb1
Compare
|
This will have to be synced once zaproxy/zaproxy#9148 is merged. |
kingthorin
force-pushed
the
migrate-params
branch
from
08bfcb1 to
966a468
Compare
Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
migrate-params
branch
from
966a468 to
46f8476
Compare
| @@ -0,0 +1,2 @@ | |||
| version=0.0.1 | |||
|
|
||
| zapAddOn { | ||
| addOnName.set("Params") | ||
| addOnStatus.set(AddOnStatus.RELEASE) |
| public void unload() { | ||
| super.unload(); | ||
|
|
||
| ExtensionPassiveScan2 extensionPassiveScan = | ||
| Control.getSingleton() | ||
| .getExtensionLoader() | ||
| .getExtension(ExtensionPassiveScan2.class); | ||
| if (extensionPassiveScan != null) { | ||
| extensionPassiveScan.getPassiveScannersManager().remove(paramScanner); | ||
| } | ||
| } |
There was a problem hiding this comment.
I seem to be missing something here but I couldn't figure out what it was.
That would mean depending on a core snapshot wouldn't it? |
|
No, can use reflection. |
|
Oh like it'll just use the functionality if available, then later when targeting 2.17 or whatever it can use the code directly? |
3 participants
Initial relocation of the Params extension/add-on from core.