fix: fix cannot write after stream was destroyed message

[zardoy]

Summary by CodeRabbit

• Documentation

  • Updated supported server version range in the README.

• Bug Fixes

  • Improved error handling to prevent crashes on packet handling failures.
  • Suppressed specific socket errors to enhance connection stability.
  • Delayed socket shutdown to ensure all pending writes complete before closing.

• New Features

  • Added event emission for every packet write to improve monitoring.

• Refactor

  • Changed message signing to be handled asynchronously.
  • Replaced destroyed client object with a stub to prevent errors after destruction.

• Style

  • Minor formatting and whitespace improvements.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the supported server version in the README, refactor the Minecraft protocol client for improved error handling and cryptographic operations, and enhance bot cleanup logic by replacing the destroyed client's write method with a warning stub to prevent errors from post-destruction packet writes.

Changes

Cohort / File(s)	Change Summary
Documentation Update README.MD	Updated the supported server version range from "1.8 - 1.21.4" to "1.8 - 1.21.5".
Protocol Client Refactor patches/minecraft-protocol.patch	Refactored the protocol client: disabled publicKey object creation and chat signature verification, made _signedChat asynchronous, altered encryption handshake to terminate on missing authentication, improved error handling with try-catch in packet emission, suppressed certain fatal errors, delayed socket shutdown for pending writes, and added a writePacket event emission on every packet write. Minor formatting changes included.
Bot Cleanup Enhancement src/index.ts	Modified bot destruction logic to assign a stub client object with a warning write method, preventing errors from post-destruction packet writes and logging a warning instead.

Sequence Diagram(s)

sequenceDiagram
    participant Bot
    participant Client
    participant Console

    Bot->>Client: destroyAll()
    Client-->>Bot: Cleanup
    Bot->>Client: _client.write(packet)
    Client-->>Console: Log warning "Attempted to write after destruction"

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Suggested labels

Review effort 3/5

Poem

A rabbit hops through code so neat,
Updating docs for a version complete.
Protocol patched with care and might,
Errors now handled, no crash in sight.
When bots are gone, no packets fly—
Just a gentle warning, not a sigh.
🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7bd26b and 9e1aace.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

• README.MD (1 hunks)
• patches/minecraft-protocol.patch (7 hunks)
• src/index.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch up-protocol

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.