Skip to content

Bump dependencies, fix integration tests #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
# if command with timeout already failed on unix, Windows job will be cancelled
- run: pnpm test-plugin
if: ${{ runner.os == 'Windows' }}
- uses: GabrielBB/[email protected]
with:
run: pnpm integration-test
Comment on lines +32 to +34
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the commit where you deleted the integration tests from the pipeline (see 774358a)

I think we should either delete integration tests entirely or add them to the pipeline.

- run: cd out && npx @vscode/vsce package --out ../extension.vsix
- name: Archive production artifacts
uses: actions/upload-artifact@v4
Expand Down
2 changes: 0 additions & 2 deletions CONTRIBUTING.MD
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ To start the VS Code plugin extension locally for developing:

#### Unit Tests

> Note: currently project doesn't use integration testing so you can ignore `integration` folder

They are in `typescript/test` and using vitest, so they faster than integration. Feel free to add new tests here. But note that most of tests are completion tests, but I do hope to add more types tests in the future.

To launch them run `pnpm test-plugin`.
Expand Down
1 change: 0 additions & 1 deletion integration/runTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ async function main() {
})
} catch (error) {
console.error(error)
console.error('Failed to run tests')
process.exit(1)
}
}
Expand Down
56 changes: 28 additions & 28 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -142,33 +142,34 @@
"postinstall": "patch-package && tsm ./typescript/scripts/patchModules.ts"
},
"devDependencies": {
"@milahu/patch-package-with-pnpm-support": "^6.4.8",
"@milahu/patch-package": "^6.4.10",
"@types/fs-extra": "^9.0.13",
"@types/node": "^16.11.21",
"@types/semver": "^7.3.13",
"@types/node": "^16.18.126",
"@types/semver": "^7.7.0",
"@types/vscode": "1.72.0",
"@vitest/ui": "^0.34.6",
"@zardoy/tsconfig": "^1.3.1",
"chokidar": "^3.5.3",
"@vitest/ui": "^0.34.7",
"@vscode/test-electron": "^2.5.2",
"@zardoy/tsconfig": "^1.5.1",
"chokidar": "^3.6.0",
"chokidar-cli": "^3.0.0",
"esbuild": "^0.16.16",
"esbuild": "^0.16.17",
"fs-extra": "^10.1.0",
"got": "^12.5.3",
"got-cjs": "npm:got@^11.x",
"got": "^12.6.1",
"got-cjs": "npm:got@^11.8.6",
"npm-run-all": "^4.1.5",
"prettier": "3.1.0",
"tsm": "^2.3.0",
"type-fest": "^2.13.1",
"type-fest": "^2.19.0",
"typed-jsonfile": "^0.2.1",
"typescript": "5.3.3",
"vite": "^4.1.1",
"typescript": "5.8.3",
"vite": "^4.5.14",
"vitest": "^0.34.6",
"vitest-environment-ts-plugin": "./vitest-environment-ts-plugin",
"vscode-manifest": "^0.0.4"
},
"pnpm": {
"overrides": {
"esbuild": "^0.15.15"
"esbuild": "^0.15.18"
},
"ignoredBuiltDependencies": [
"playwright"
Expand All @@ -181,37 +182,36 @@
]
},
"dependencies": {
"@types/chai": "^4.3.3",
"@types/glob": "^8.0.0",
"@types/lodash": "^4.14.182",
"@types/chai": "^4.3.20",
"@types/glob": "^8.1.0",
"@types/lodash": "^4.17.20",
"@types/mocha": "^9.1.1",
"@types/pluralize": "^0.0.29",
"@vscode/emmet-helper": "^2.8.4",
"@vscode/test-electron": "^2.1.5",
"@vscode/emmet-helper": "^2.11.0",
"@zardoy/utils": "^0.0.9",
"@zardoy/vscode-utils": "^0.0.52",
"chai": "^4.3.6",
"chai": "^4.5.0",
"change-case": "^4.1.2",
"delay": "^5.0.0",
"escape-string-regexp": "^5.0.0",
"eslint": "^8.56.0",
"eslint": "^8.57.1",
"eslint-config-zardoy": "^0.2.17",
"glob": "^8.0.3",
"glob": "^8.1.0",
"lodash": "^4.17.21",
"lodash.get": "^4.4.2",
"lodash.throttle": "^4.1.1",
"mocha": "^10.0.0",
"mocha": "^10.8.2",
"path-browserify": "^1.0.1",
"pluralize": "github:plurals/pluralize#36f03cd2d573fa6d23e12e1529fa4627e2af74b4",
"rambda": "^7.2.1",
"rambda": "^7.5.0",
"require-from-string": "^2.0.2",
"semver": "^7.3.8",
"string-dedent": "^3.0.1",
"ts-expose-internals": "^5.3.3",
"semver": "^7.7.2",
"string-dedent": "^3.0.2",
"ts-expose-internals": "^5.6.3",
"ts-simple-type": "^1.0.7",
"unleashed-typescript": "^1.3.0",
"vscode-framework": "^0.0.18",
"vscode-uri": "^3.0.6"
"vscode-uri": "^3.1.0"
},
"prettier": {
"semi": false,
Expand All @@ -231,5 +231,5 @@
"runTest": false
}
},
"packageManager": "pnpm@10.12.1+sha512.f0dda8580f0ee9481c5c79a1d927b9164f2c478e90992ad268bbb2465a736984391d6333d2c327913578b2804af33474ca554ba29c04a8b13060a717675ae3ac"
"packageManager": "pnpm@10.13.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zardoy Why did you choose this specific pnpm build?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use corepack. Core pack automatically adds this field when any pnpm command is run. This was the latest pnpm build at that time

}
35 changes: 0 additions & 35 deletions patches/@vscode+test-electron+2.1.5.patch

This file was deleted.

Loading
Loading