Handle uncompressed variables in parsing metadata#207
Closed
ghidalgo3 wants to merge 2 commits intozarr-developers:support/v1from
Closed
Handle uncompressed variables in parsing metadata#207ghidalgo3 wants to merge 2 commits intozarr-developers:support/v1from
ghidalgo3 wants to merge 2 commits intozarr-developers:support/v1from
Conversation
ghidalgo3
commented
Aug 2, 2024
| _configurable_to_num_codec_config(_filter) for _filter in all_codecs | ||
| ] | ||
| # Uncompressed variables may have no codecs | ||
| if num_codec_configs: |
Contributor
Author
There was a problem hiding this comment.
Is len(num_codec_configs) > 0 better? Or not empty(num_codec_configs)?
Member
There was a problem hiding this comment.
Does this actually cover all cases? What if you have an uncompressed variable that does have other codecs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading in a ZarrV3 store, it is very possible that a variable is uncompressed. The code that assigns codecs to
compressorsandfiltersdoesn't handle the case when there are no codecs to assign. This PR addresses that gap.docs/releases.rst