Skip to content

Conversation

@maxrjones
Copy link
Member

@TomNicholas @norlandrhagen should the authors in citations.cff be based on https://github.com/orgs/zarr-developers/teams/virtualizarr-core-devs, git shortlog -sne, or some combination?

p.s. if you write a JOSS article it could be added as the preferred citation similar to Xarray's Journal of Open Research Software article

Closes #305

@TomNicholas TomNicholas added the documentation Improvements or additions to documentation label Dec 11, 2024
Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @maxrjones ! (I mean I did write this guide orginally haha)

@TomNicholas
Copy link
Member

authors in citations.cff

I think it kind of needs to be a manually-chosen list. I added somewhat random (trusted) people to that list the core-devs github team to reduce the bus factor initially. And there are people I think deserve to get the citations who haven't actually contributed code to this library directly and aren't on that core-devs list (I'm thinking mainly of @martindurant).

@maxrjones
Copy link
Member Author

authors in citations.cff

I think it kind of needs to be a manually-chosen list. I added somewhat random (trusted) people to that list the core-devs github team to reduce the bus factor initially. And there are people I think deserve to get the citations who haven't actually contributed code to this library directly and aren't on that core-devs list (I'm thinking mainly of @martindurant).

Sounds good, sorry to put this on you but I think you and @norlandrhagen should come up with this initial list as the most consistent VirtualiZarr developers so far (as shown by https://github.com/zarr-developers/VirtualiZarr/graphs/contributors).

@TomNicholas
Copy link
Member

Sounds good, sorry to put this on you but I think you and @norlandrhagen should come up with this initial list

No worries - I literally already have a written ToDo somewhere where I started doing this.

@TomNicholas TomNicholas mentioned this pull request Mar 2, 2025
@maxrjones maxrjones changed the base branch from main to develop April 11, 2025 01:35
@maxrjones
Copy link
Member Author

FYI @TomNicholas I pulled your list from #459. I'm going to merge this since it has an approval and is better than nothing.

@maxrjones maxrjones merged commit 552396b into develop Apr 11, 2025
10 checks passed
@maxrjones maxrjones deleted the citation.cff branch April 11, 2025 01:39
sharkinsspatial pushed a commit that referenced this pull request Apr 11, 2025
* Add citation.cff and core team guide

* Apply suggestions from code review

Co-authored-by: Tom Nicholas <[email protected]>

* Fix link to contributing guide

* Add authors listed in #459

* Format

---------

Co-authored-by: Tom Nicholas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOI?

3 participants