Revert "Align HDF reader CF _FillValue with Zarr v3 semantics (#420)" #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evelopers#420)" This reverts commit c461b33.
Member
Author
|
Okay that passed really quickly, there's definitely something up with #420. Merging this |
Member
|
Thanks @TomNicholas FYI @sharkinsspatial I un-deleted https://github.com/zarr-developers/VirtualiZarr/tree/fix/fill_value if you want to open a new PR to work on that more. |
chuckwondo
added a commit
to chuckwondo/VirtualiZarr
that referenced
this pull request
Mar 3, 2025
maxrjones
pushed a commit
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c461b33, i.e. PR #420, based on @maxrjones' comment in #454.
FYI @sharkinsspatial @chuckwondo